Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable linting for tests #1632

Merged
merged 4 commits into from
Sep 19, 2024
Merged

CI: Enable linting for tests #1632

merged 4 commits into from
Sep 19, 2024

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 16, 2024

Summary

I noticed linting isn't enabled for tests in the indexer repo, like it is in go-algorand, and think it would help catch issues with tests if it were. Enabled linting for tests in this PR and fixed the lint warnings.

Test Plan

Existing tests should pass and introduce new assertions (like previously unchecked errors)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (249016c) to head (cf7bbd7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files          37       37           
  Lines        7375     7375           
=======================================
  Hits         5118     5118           
  Misses       1839     1839           
  Partials      418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf merged commit ecbedc4 into main Sep 19, 2024
8 checks passed
@gmalouf gmalouf deleted the lint-tests branch September 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants