Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release notes template formatting. #1571

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Aug 31, 2023

Summary

There were two issues with the new release template:

  • missing forward slash in the diff URL.
  • The triple-dash separator turned the changelog into a header, which was not intentional.

@winder winder requested a review from a team August 31, 2023 19:39
@winder winder self-assigned this Aug 31, 2023
@winder winder requested review from tzaffi, Eric-Warehime, shiqizng and algochoi and removed request for a team August 31, 2023 19:39
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1571 (1d54091) into develop (e47b81f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1571   +/-   ##
========================================
  Coverage    68.58%   68.58%           
========================================
  Files           37       37           
  Lines         7417     7417           
========================================
  Hits          5087     5087           
  Misses        1903     1903           
  Partials       427      427           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ 👍

@winder winder added the Enhancement New feature or request label Sep 1, 2023
@winder winder merged commit d9c41d9 into algorand:develop Sep 1, 2023
4 of 6 checks passed
@winder winder deleted the will/fix-goreleaser-template branch September 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Team Lamprey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants