idb(postgres): add protocol version check before writing to database. #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1506 +/- ##
===========================================
- Coverage 70.33% 70.31% -0.02%
===========================================
Files 70 70
Lines 9680 9685 +5
===========================================
+ Hits 6808 6810 +2
- Misses 2375 2377 +2
- Partials 497 498 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
reviewed
Mar 15, 2023
| @@ -175,6 +175,12 @@ func (db *IndexerDb) init(opts idb.IndexerDbOptions) (chan struct{}, error) { | |||
|
|
|||
| // AddBlock is part of idb.IndexerDb. | |||
| func (db *IndexerDb) AddBlock(vb *itypes.ValidatedBlock) error { | |||
| protoVersion := protocol.ConsensusVersion(vb.Block.CurrentProtocol) | |||
| _, ok := config.Consensus[protoVersion] | |||
There was a problem hiding this comment.
this reminds me of EnableAssetCloseAmount. do we still need to support AssetCloseAmount for the older txns? maybe it's one of the things we can deprecate in the next release?
There was a problem hiding this comment.
I don't think we need to touch the API right now. This check is mainly to ensure you're running with up to date software. i.e. imagine a new txn field is added.
shiqizng
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure the block being written is for a known protocol version.