Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-exporter: Use strict encoding when writing files. #1488

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Mar 1, 2023

Summary

Use strict encoding when writing the block files.

Test Plan

New unit tests.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1488 (bfe704c) into develop (c462ef0) will decrease coverage by 0.02%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop    #1488      +/-   ##
===========================================
- Coverage    65.44%   65.42%   -0.02%     
===========================================
  Files           82       82              
  Lines        11447    11459      +12     
===========================================
+ Hits          7491     7497       +6     
- Misses        3387     3391       +4     
- Partials       569      571       +2     
Impacted Files Coverage Δ
util/util.go 84.15% <90.47%> (+1.11%) ⬆️
...duit/plugins/exporters/filewriter/file_exporter.go 76.78% <100.00%> (ø)
conduit/plugins/importers/filereader/filereader.go 88.33% <100.00%> (ø)
fetcher/fetcher.go 62.71% <0.00%> (-1.28%) ⬇️
idb/postgres/postgres.go 65.49% <0.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

conduit/plugins/exporters/filewriter/file_exporter_test.go Outdated Show resolved Hide resolved
util/util_test.go Outdated Show resolved Hide resolved
@winder winder merged commit b39ad77 into algorand:develop Mar 1, 2023
@winder winder deleted the will/file-writer-keys branch March 1, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants