Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix missing var initialize. #1451

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jan 31, 2023

Summary

Not sure how I missed this.

@Eric-Warehime
Copy link
Contributor

I was actually looking at this as well...seems like somehow there wasn't a git conflict despite both 92991d8 and c755f42 modifying the same file.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1451 (8f5aa33) into develop (29d5663) will increase coverage by 0.22%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           develop    #1451      +/-   ##
===========================================
+ Coverage    65.14%   65.37%   +0.22%     
===========================================
  Files           80       83       +3     
  Lines        11381    11404      +23     
===========================================
+ Hits          7414     7455      +41     
+ Misses        3395     3379      -16     
+ Partials       572      570       -2     
Impacted Files Coverage Δ
conduit/pipeline/pipeline.go 64.32% <66.66%> (+0.64%) ⬆️
conduit/plugins/importers/algod/algod_importer.go 82.60% <100.00%> (+4.58%) ⬆️
conduit/plugins/importers/algod/metrics.go 100.00% <100.00%> (ø)
.../importers/algodfollower/algodfollower_importer.go 78.43% <100.00%> (+4.17%) ⬆️
conduit/plugins/importers/algodfollower/metrics.go 100.00% <100.00%> (ø)
...ugins/processors/blockprocessor/block_processor.go 73.89% <100.00%> (+1.71%) ⬆️
...nduit/plugins/processors/blockprocessor/metrics.go 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review January 31, 2023 20:31
@winder winder merged commit 323ff96 into algorand:develop Feb 1, 2023
@winder winder deleted the will/fix-missing-var branch February 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants