Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix lint/vet #1445

Merged
merged 3 commits into from
Jan 30, 2023
Merged

build: Fix lint/vet #1445

merged 3 commits into from
Jan 30, 2023

Conversation

Eric-Warehime
Copy link
Contributor

Summary

It looks like make lint is failing on a few things--not sure how some of these ever passed CI, but here are the fixes.

  • The fmt string in conduit/plugins/processors/filterprocessor/gen/generate.go is being skipped for linting, but go vet is failing. Use bytes.Buffer.WriteString instead of fmt.Fprint.
  • There are leftover references to appCall in handlers_e2e_test.go where appCall was commented out for the refactoring work. Comment these out.
  • It looks like we missed a conversion to v2 of the SDK in api/util_test.go.

api/handlers_e2e_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1445 (4400f6a) into develop (451d4b3) will increase coverage by 0.02%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##           develop    #1445      +/-   ##
===========================================
+ Coverage    65.13%   65.15%   +0.02%     
===========================================
  Files           80       80              
  Lines        11376    11377       +1     
===========================================
+ Hits          7410     7413       +3     
+ Misses        3394     3393       -1     
+ Partials       572      571       -1     
Impacted Files Coverage Δ
...plugins/processors/filterprocessor/gen/generate.go 0.00% <0.00%> (ø)
idb/idb.go 69.35% <ø> (ø)
api/converter_utils.go 92.65% <100.00%> (+0.03%) ⬆️
api/handlers.go 75.60% <100.00%> (+0.13%) ⬆️
idb/postgres/postgres.go 65.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algochoi and others added 2 commits January 30, 2023 12:16
Re-introduce `appcall` variable in inner txn tests
@winder winder merged commit 255db8f into algorand:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants