Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like
make lint
is failing on a few things--not sure how some of these ever passed CI, but here are the fixes.conduit/plugins/processors/filterprocessor/gen/generate.go
is being skipped for linting, butgo vet
is failing. Usebytes.Buffer.WriteString
instead offmt.Fprint
.appCall
inhandlers_e2e_test.go
whereappCall
was commented out for the refactoring work. Comment these out.api/util_test.go
.