metrics: Configurable conduit metrics prefix. #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1353 +/- ##
===========================================
+ Coverage 62.78% 63.16% +0.38%
===========================================
Files 76 76
Lines 10377 10480 +103
===========================================
+ Hits 6515 6620 +105
+ Misses 3303 3301 -2
Partials 559 559
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
reviewed
Nov 30, 2022
Eric-Warehime
approved these changes
Dec 2, 2022
winder
force-pushed
the
will/configurable-prometheus-prefix
branch
from
07163ea
to
3681d65
Compare
winder
force-pushed
the
will/configurable-prometheus-prefix
branch
from
a8e8cb7
to
3342430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a configuration to the metrics prefix so that conduit can be different than Indexer.
Test Plan