tech debt: Indexer initialization improvements #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
- Coverage 62.78% 60.71% -2.08%
===========================================
Files 76 76
Lines 10377 10909 +532
===========================================
+ Hits 6515 6623 +108
- Misses 3303 3699 +396
- Partials 559 587 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
commented
Nov 30, 2022
Comment on lines
-108
to
+109
| panic(exit{1}) | ||
| fmt.Fprintf(os.Stderr, "Exiting with error: %s\n", err.Error()) | ||
| os.Exit(1) |
There was a problem hiding this comment.
We weren't printing errors returned from runDaemon!
Panic is no longer needed, if daemon returns then defer was able to run properly.
* Print correct logfile. * Do not use logger before initialized. * Do not require data dir in read-only mode.
winder
force-pushed
the
will/init-improvements
branch
from
d35f886
to
cb0a2ec
Compare
AlgoStephenAkiki
approved these changes
Dec 6, 2022
Eric-Warehime
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BindFlagSettwice.panicwith an error return.Test Plan
Existing / new unit tests.
Manual testing.