Changed tag format #1238
Changed tag format #1238
Conversation
AlgoStephenAkiki
force-pushed
the
1223-filter-plugin-followup-features
branch
from
0b185dc
to
6eb9068
Compare
AlgoStephenAkiki
force-pushed
the
1223-filter-plugin-followup-features
branch
from
6eb9068
to
9dfcd13
Compare
Codecov Report
@@ Coverage Diff @@
## conduit #1238 +/- ##
===========================================
- Coverage 62.09% 60.16% -1.94%
===========================================
Files 70 73 +3
Lines 9387 9857 +470
===========================================
+ Hits 5829 5930 +101
- Misses 3059 3419 +360
- Partials 499 508 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "sort" | ||
| "strings" | ||
|
|
||
| "github.com/algorand/go-algorand/data/transactions" |
There was a problem hiding this comment.
Does this work if you use the transaction object from the go SDK?
There was a problem hiding this comment.
Perhaps. Is it easy to test by importing the sdk?
There was a problem hiding this comment.
Indexer uses the SDK, so I think you could swap in the other type: https://github.com/algorand/go-algorand-sdk/blob/develop/types/transaction.go#L25
It looks like SignedTxnWithAD isn't available, but I'm not sure that one is especially useful so maybe this is OK?
There was a problem hiding this comment.
AD contains information regarding the application ID for ASA's or apps (at least according to the comments) as well rewards applied to the sender/receiver. Is that used by customers?
There was a problem hiding this comment.
Good point about the IDs, that might be the only place it is available when things are being created.
Sorry, which issue is this actually resolving? |
| var exp Expression | ||
|
|
||
| switch targetKind { | ||
| case reflect.TypeOf(basics.MicroAlgos{}).Kind(): |
There was a problem hiding this comment.
You could put this check in the generator. If the leaf type is MicroAlgos add the extra Raw reference:
case "txn.fee":
- return &input.SignedTxnWithAD.SignedTxn.Txn.Header.Fee, nil
+ return &input.SignedTxnWithAD.SignedTxn.Txn.Header.Fee.Raw, nil
Resolves #1238
Changes tag format and adds numerical filtering