-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conduit: init subcommand #1235
Conduit: init subcommand #1235
Conversation
97e7f5c
to
92ec78b
Compare
Codecov Report
@@ Coverage Diff @@
## conduit #1235 +/- ##
========================================
Coverage 62.06% 62.06%
========================================
Files 70 70
Lines 9434 9434
========================================
Hits 5855 5855
Misses 3073 3073
Partials 506 506
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cfg.Flags = conduitCmd.PersistentFlags() | ||
cfg.Flags = cmd.Flags() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes the flags to the sub commands, which I didn't want.
return cmd | ||
} | ||
|
||
//go:embed conduit.yml.example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very cool
…imple configuration.
92ec78b
to
9a14579
Compare
Summary
Note: this is building ontop of #1232 so there are some unrelated changes in the diff.
Thinking out loud a little with this PR. I wanted to try out Conduit and getting the basic configuration setup was a little tricky.
Run
./conduit init
or./conduit init -d /path/to/data/directory
and a new directory is created along with some instructions:Test Plan
New unit test and manual testing.