conduit bugfix: silence usage data on error #1205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cobra prints usage data when the RunE function exits with an error, but that's pretty counterintuitive. If an error returned from conduit is on account of improper usage, the error should contain the proper info.
Cobra has an open issue about the need for docs on this as well. Found this solution there spf13/cobra#914
Test Plan
After fix (running using changes in #1204 )