Add waits/retries to algod importer #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
added
Not-Yet-Enabled
Eric-Warehime
requested review from
winder,
shiqizng,
AlgoStephenAkiki and
algoganesh
Codecov Report
@@ Coverage Diff @@
## conduit #1178 +/- ##
==========================================
Coverage ? 59.03%
==========================================
Files ? 64
Lines ? 8883
Branches ? 0
==========================================
Hits ? 5244
Misses ? 3170
Partials ? 469 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "path" | ||
| "strconv" | ||
| "strings" | ||
| "github.com/algorand/indexer/util/test" |
AlgoStephenAkiki
approved these changes
Aug 15, 2022
shiqizng
approved these changes
Aug 15, 2022
fetcher/fetcher_test.go
Outdated
| // returning an empty block `passingCalls` times before throwing 500s | ||
| func(path string, w http.ResponseWriter) bool { | ||
| if strings.Contains(path, "v2/blocks/") { | ||
| if passingCalls <= 0 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Indexer's fetcher uses the GetBlock API while catching up since it knows the blocks should exist, and adds a WaitForBlock call during follow.
I've added a wait call for each block fetch so that fetching blocks via the Algod Importer should function properly for both older blocks and new ones.
I've also refactored the mock algod server used in these tests and the fetcher tests to use a common package.
Also added files to the codecov ignore list since they are mocks/tests.
Test Plan
Added/updated unit tests.