Conduit: Algod importer implementation #1135
Conversation
algoganesh
requested review from
winder,
Eric-Warehime,
shiqizng and
AlgoStephenAkiki
Codecov Report
@@ Coverage Diff @@
## conduit #1135 +/- ##
==========================================
Coverage ? 60.65%
==========================================
Files ? 56
Lines ? 8435
Branches ? 0
==========================================
Hits ? 5116
Misses ? 2857
Partials ? 462 Help us with your feedback. Take ten seconds to tell us how you rate us. |
docs/rfc/0003-importer-interface.md
Outdated
| type Importer interface { | ||
| // GetBlock given any round number rnd fetches the block at that round | ||
| // It returns an object of type BlockExportData defined in exporters plugin | ||
| GetBlock(rnd uint64) (*exporters.BlockExportData, error) |
There was a problem hiding this comment.
does the processor take block of type exporters.BlockExportData too?
There was a problem hiding this comment.
It should. I think we're still trying to figure out what the best data format is to pass between all of the plugin.
Some discussion happening in #1119 (comment)
algoganesh
force-pushed
the
algod-importer-impl
branch
from
c6b9cb0 to
027ab87
Compare
algoganesh
force-pushed
the
algod-importer-impl
branch
2 times, most recently
from
cb0acac to
777f722
Compare
algoganesh
force-pushed
the
algod-importer-impl
branch
from
777f722 to
6e4fe83
Compare
| return err | ||
| } | ||
| if u.Scheme != "http" && u.Scheme != "https" { | ||
| algodImp.cfg.NetAddr = "http://" + algodImp.cfg.NetAddr |
There was a problem hiding this comment.
I think its a good idea to log it
| s = "" | ||
| } | ||
|
|
||
| func MockAlgodServerReturnsEmptyBlock() *httptest.Server { |
There was a problem hiding this comment.
We have somewhat similar code in https://github.com/algorand/indexer/blob/develop/fetcher/fetcher_test.go#L103
Also, Will mentioned that block-generator might be doing the same. We should look to refactor these into commonly used conventions for mocking Algod in the future.
There was a problem hiding this comment.
I agree. Also MockAlgodServerReturnsEmptyBlock() is intentionally exported for other plugins to utilize in testing.
…god-importer-impl merge conduit into branch
Co-authored-by: Eric Warehime <[email protected]>
Summary
Defines interface for importer plugins and a sample implementation of importer interface using
algodrest endpoint.