Remove the updates and participation params

Remove the `updates` and `participation` parameters from `GET /v2/block-headers`. The underlying SQL code is now simpler.
algorand · Nov 21, 2024 · 8cb90c1 · 8cb90c1
1 parent a302e5b
commit 8cb90c1
Show file tree

Hide file tree

Showing 8 changed files with 435 additions and 675 deletions.
diff --git a/api/converter_utils.go b/api/converter_utils.go
@@ -897,14 +897,8 @@ func (si *ServerImplementation) blockParamsToBlockFilter(params generated.Search
 		if params.Absent != nil {
 			numParticipationFilters++
 		}
-		if params.Updates != nil {
-			numParticipationFilters++
-		}
-		if params.Participation != nil {
-			numParticipationFilters++
-		}
 		if numParticipationFilters > 1 {
-			errorArr = append(errorArr, "only one of `proposer`, `expired`, `absent`, `updates`, or `participation` can be specified")
+			errorArr = append(errorArr, "only one of `proposer`, `expired`, or `absent` can be specified")
 		}
 
 		// Validate the number of items in the participation account lists
@@ -917,12 +911,6 @@ func (si *ServerImplementation) blockParamsToBlockFilter(params generated.Search
 		if params.Absent != nil && uint64(len(*params.Absent)) > si.opts.MaxAccountListSize {
 			errorArr = append(errorArr, fmt.Sprintf("absent list too long, max size is %d", si.opts.MaxAccountListSize))
 		}
-		if params.Updates != nil && uint64(len(*params.Updates)) > si.opts.MaxAccountListSize {
-			errorArr = append(errorArr, fmt.Sprintf("updates list too long, max size is %d", si.opts.MaxAccountListSize))
-		}
-		if params.Participation != nil && uint64(len(*params.Participation)) > si.opts.MaxAccountListSize {
-			errorArr = append(errorArr, fmt.Sprintf("participation list too long, max size is %d", si.opts.MaxAccountListSize))
-		}
 
 		filter.Proposers = make(map[sdk.Address]struct{}, 0)
 		if params.Proposer != nil {
@@ -950,27 +938,6 @@ func (si *ServerImplementation) blockParamsToBlockFilter(params generated.Search
 				filter.AbsentParticipationAccounts[addr] = struct{}{}
 			}
 		}
-
-		// Updates = absent || expired
-		if params.Updates != nil {
-			for _, s := range *params.Updates {
-				var addr sdk.Address
-				addr, errorArr = decodeAddress(s, "updates", errorArr)
-				filter.AbsentParticipationAccounts[addr] = struct{}{}
-				filter.ExpiredParticipationAccounts[addr] = struct{}{}
-			}
-		}
-
-		// Participation = proposer || absent || expired
-		if params.Participation != nil {
-			for _, s := range *params.Participation {
-				var addr sdk.Address
-				addr, errorArr = decodeAddress(s, "participation", errorArr)
-				filter.Proposers[addr] = struct{}{}
-				filter.AbsentParticipationAccounts[addr] = struct{}{}
-				filter.ExpiredParticipationAccounts[addr] = struct{}{}
-			}
-		}
 	}
 
 	// If there were any errorArr while setting up the BlockFilter, return now.

diff --git a/api/generated/common/routes.go b/api/generated/common/routes.go
diff --git a/api/generated/common/types.go b/api/generated/common/types.go
diff --git a/api/generated/v2/routes.go b/api/generated/v2/routes.go
diff --git a/api/generated/v2/types.go b/api/generated/v2/types.go
diff --git a/api/indexer.oas2.json b/api/indexer.oas2.json
@@ -893,12 +893,6 @@
           },
           {
             "$ref": "#/parameters/absent"
-          },
-          {
-            "$ref": "#/parameters/updates"
-          },
-          {
-            "$ref": "#/parameters/participation"
           }
         ],
         "responses": {
@@ -2771,28 +2765,6 @@
       "in": "query",
       "required": false
     },
-    "updates": {
-      "type": "array",
-      "items": {
-        "type": "string",
-        "x-algorand-format": "Address"
-      },
-      "description": "Accounts marked as expired or absent in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-      "name": "updates",
-      "in": "query",
-      "required": false
-    },
-    "participation": {
-      "type": "array",
-      "items": {
-        "type": "string",
-        "x-algorand-format": "Address"
-      },
-      "description": "Accounts marked as expired, absent or as proposer in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-      "name": "participation",
-      "in": "query",
-      "required": false
-    },
     "account-id": {
       "type": "string",
       "description": "account string",

diff --git a/api/indexer.oas3.yml b/api/indexer.oas3.yml
@@ -221,20 +221,6 @@
         },
         "x-algorand-format": "base64"
       },
-      "participation": {
-        "description": "Accounts marked as expired, absent or as proposer in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-        "explode": false,
-        "in": "query",
-        "name": "participation",
-        "schema": {
-          "items": {
-            "type": "string",
-            "x-algorand-format": "Address"
-          },
-          "type": "array"
-        },
-        "style": "form"
-      },
       "proposer": {
         "description": "Accounts marked as proposer in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
         "explode": false,
@@ -320,20 +306,6 @@
         "schema": {
           "type": "string"
         }
-      },
-      "updates": {
-        "description": "Accounts marked as expired or absent in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-        "explode": false,
-        "in": "query",
-        "name": "updates",
-        "schema": {
-          "items": {
-            "type": "string",
-            "x-algorand-format": "Address"
-          },
-          "type": "array"
-        },
-        "style": "form"
       }
     },
     "responses": {
@@ -4963,34 +4935,6 @@
               "type": "array"
             },
             "style": "form"
-          },
-          {
-            "description": "Accounts marked as expired or absent in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-            "explode": false,
-            "in": "query",
-            "name": "updates",
-            "schema": {
-              "items": {
-                "type": "string",
-                "x-algorand-format": "Address"
-              },
-              "type": "array"
-            },
-            "style": "form"
-          },
-          {
-            "description": "Accounts marked as expired, absent or as proposer in the block header's participation updates. This parameter accepts a comma separated list of addresses.",
-            "explode": false,
-            "in": "query",
-            "name": "participation",
-            "schema": {
-              "items": {
-                "type": "string",
-                "x-algorand-format": "Address"
-              },
-              "type": "array"
-            },
-            "style": "form"
           }
         ],
         "responses": {