Fix for TestCatchupOverGossip failed in nightly#926
Merged
tsachiherman merged 1 commit intoalgorand:masterfrom Mar 23, 2020
Merged
Conversation
t.Parallel is getting called multiple times in the same test. This bug was introduced when the test was refactored so it can be called multiple times with different configurations. t.parallel was left in the body of the test called multiple times. It is a puzzle why it was passing before, but now it is failing.
tsachiherman
approved these changes
Mar 23, 2020
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks good, thanks for fixing these.
pzbitskiy
approved these changes
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Parallel is getting called multiple times in the same test. This
bug was introduced when the test was refactored so it can be called
multiple times with different configurations. t.parallel was left in
the body of the test called multiple times. It is a puzzle why it was
passing before, but now it is failing.