Improve error logging on nextRoundIsNotSupported#920
Merged
tsachiherman merged 1 commit intoalgorand:masterfrom Mar 20, 2020
Merged
Conversation
algonautshant
approved these changes
Mar 19, 2020
Contributor
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
looks good. thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The error logging that we've had at
nextRoundIsNotSupportedwasn't that great.In this PR, I have extended that to contain the originating error from the database.
This would hopefully give us some better idea of what went wrong and allow us to address the originating issue.
Resolves #911