Catchup service through gossip connections using the topics#913
Merged
tsachiherman merged 10 commits intoalgorand:masterfrom Mar 20, 2020
Merged
Catchup service through gossip connections using the topics#913tsachiherman merged 10 commits intoalgorand:masterfrom
tsachiherman merged 10 commits intoalgorand:masterfrom
Conversation
tsachiherman
suggested changes
Mar 12, 2020
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
Few requested changes above; I haven't reviewed the unit testing yet.
tsachiherman
suggested changes
Mar 16, 2020
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
Could you address the topics issue mentioned, and add unit testing for the error cases ?
( i.e. test to see that you get the expected error string. )
hint : make the error string a const error and test against that string.
* Introduce versioning: old: 1, new: 2.1 * Add keys to topics as const in topics.go * Introduce MakeTopic to create topics without exporting the Topic fields * Change wsPeer.Respond to accept Topics instead of OutgoingMessage * Add methods: Version, Request, Respond to UnicastPeer interface (should rename UnicastPeer?) * Make LedgerService handleCatchupReq support v2.1 (request/respond using topics) * Make WsFetcherService RequestBlock support v2.1 (request/respond using topics) Modifying TestGetBlockWS to test version 2.1
* Moving the const topic keys to their respective packages * Enhancing error checking and error reporting * Switching the block order for v1 and v2.1
…rror reporting bug.
…erriding the network protocol version. * Added Version() function to UnicastPeer interface to return the peer matching version. * Added cross-network-version catchup e2e test * Allowed TestCatchupOverGossip to run on darwin * Fixed RestClientFixture SetupNoStart
algonautshant
force-pushed
the
shant/peerCatchup
branch
from
392ec29 to
e7856c7
Compare
tsachiherman
approved these changes
Mar 20, 2020
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks good. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying TestGetBlockWS to test version 2.1
Test Plan
Will add e2e test to test all cases of the two version combinations.