Skip to content

Improve some error checking and logging for build process #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 2 commits into from
Feb 26, 2020
Merged

Improve some error checking and logging for build process #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f39d3b
Improve some error checking and logging for build process
Feb 25, 2020
fa45820
Merge branch 'master' into misc_build_updates
Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/release/common/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ export BRANCH

# Check out
mkdir -p "${HOME}/go/src/github.com/algorand"
cd "${HOME}/go/src/github.com/algorand" && git clone --single-branch --branch "${BRANCH}" https://github.com/algorand/go-algorand go-algorand
cd "${HOME}/go/src/github.com/algorand"
if ! git clone --single-branch --branch "${BRANCH}" https://github.com/algorand/go-algorand go-algorand
then
echo There has been a problem cloning the "$BRANCH" branch.
exit 1
fi

# TODO: if we are checking out a release tag, `git tag --verify` it

export DEBIAN_FRONTEND=noninteractive
Expand Down Expand Up @@ -95,7 +101,11 @@ EOF
# Install aptly for building debian repo
mkdir -p "$GOPATH/src/github.com/aptly-dev"
cd "$GOPATH/src/github.com/aptly-dev"
git clone https://github.com/aptly-dev/aptly
if ! git clone https://github.com/aptly-dev/aptly
then
echo There has been a problem cloning the aptly project.
exit 1
fi
cd aptly && git fetch

# As of 2019-06-06 release tag v1.3.0 is 2018-May, GnuPG 2 support was added in October but they haven't tagged a new release yet. Hash below seems to work so far.
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/util/smoke_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ SHORT_HASH=${HASH:0:8}
# Use a regex over the multi-line string.
if [[ "$STR" =~ .*"$RELEASE.$CHANNEL [$BRANCH] (commit #$SHORT_HASH)".* ]]
then
echo "$GREEN_FG[$0]$END_FG_COLOR The result of \`algod -v\` is a correct match."
echo -e "$GREEN_FG[$0]$END_FG_COLOR The result of \`algod -v\` is a correct match.\n$STR"
exit 0
fi

Expand Down
4 changes: 2 additions & 2 deletions scripts/release/util/test_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ check_failures() {

build_images
check_failures built
echo "$GREEN_FG[$0]$END_FG_COLOR Builds completed with no failures."
echo "$GREEN_FG[$0]$END_FG_COLOR All builds completed with no failures."

run_images
check_failures verified
echo "$GREEN_FG[$0]$END_FG_COLOR Runs completed with no failures."
echo "$GREEN_FG[$0]$END_FG_COLOR All runs completed with no failures."

cleanup