Skip to content

Skip unit test TestFirstListenerSetupGetsPort8080WhenPassedPortZero #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeldovich merged 4 commits into from
Jun 21, 2019
Merged

Skip unit test TestFirstListenerSetupGetsPort8080WhenPassedPortZero #73

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f6de0e
Merge pull request #1 from algorand/master
tsachiherman Jun 17, 2019
4d22065
Merge pull request #3 from algorand/master
tsachiherman Jun 19, 2019
860849f
Skip test for taking port 8080 when this port is already in use.
tsachizehub Jun 21, 2019
13d0d95
fix typo.
tsachizehub Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions daemon/algod/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,35 @@ package algod
// this should make dummy requests against the API and check the results for consistency

import (
"fmt"
"net"
"testing"

"github.com/stretchr/testify/require"
)

func isTCPPortAvailable(host string, port int) bool {
l, err := net.Listen("tcp", fmt.Sprintf("%s:%d", host, port))
if l != nil {
l.Close()
}
return err == nil
}
func TestFirstListenerSetupGetsPort8080WhenPassedPortZero(t *testing.T) {
// this test will fail if there is already a listener on the testing machine's port 8080
// (ex if a dev has a node running on port 8080 and runs the test, it will fail)
defaultAddr := "127.0.0.1:0"
expectedAddr := "127.0.0.1:8080"
// (except if a dev has a node running on port 8080 and runs the test; in that case, we can't run this test.)
targetPort := 8080
host := "127.0.0.1"
// check if port 8080 is busy :
if !isTCPPortAvailable(host, targetPort) {
t.Skipf("Cannot run this test since port 8080 is already in use.")
}
defaultAddr := host + ":0"
expectedAddr := fmt.Sprintf("%s:%d", host, targetPort)
listener, err := makeListener(defaultAddr)
require.NoError(t, err)
actualAddr := listener.Addr().String()
require.Equal(t, expectedAddr, actualAddr, "if port 8080 is occupied when this test runs, it will fail")
require.Equalf(t, expectedAddr, actualAddr, "if port %d is occupied when this test runs, it will fail", targetPort)
}

func TestSecondListenerSetupGetsAnotherPortWhen8080IsBusy(t *testing.T) {
Expand Down