Skip to content

Build release job#698

Merged
tsachiherman merged 57 commits intoalgorand:masterfrom
btoll:build_test
Jan 15, 2020
Merged

Build release job#698
tsachiherman merged 57 commits intoalgorand:masterfrom
btoll:build_test

Conversation

@btoll
Copy link
Copy Markdown

@btoll btoll commented Jan 8, 2020

This is my original feature branch. I've been working off of this again because I was getting odd linker errors when go was building on the other branch (you can see this here #690).

Rather than go down a rabbit hole, I merged what I needed back into this feature branch and kept moving.

Please see the README for details.


cat <<EOF>"${HOME}/.rpmmacros"
%_gpg_name Algorand RPM <rpm@algorand.com>
%_gpg_name ALGORAND RPM <rpm@algorand.com>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure the real key's username isn't all caps

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're right.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just saw that's in archive. I'm going to remove that directory as soon as this has settled. I probably shouldn't have versioned that!

trap "rm -rf ${RPMTMP}" 0
scripts/build_rpm.sh ${RPMTMP}
cp -p ${RPMTMP}/*/*.rpm /root/subhome/node_pkg
trap 'rm -rf ${RPMTMP}' 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be doublequote so that $RPMTMP is substituted in

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revisit this.


set -e
set -x
#set -ex
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turn this back on?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will, I want to make sure I'm not getting any false positives while I'm still running builds. I should've left a comment explaining that.

#https://releases.algorand.com/key.pub
#gpgkeys: protocol `https' not supported

curl -o /root/stuff/key.pub https://releases.algorand.com/key.pub
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure at this stage we want to test with the fake key, not the real key from releases; or did this test move to later in the flow after signing the real thing?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

Comment thread scripts/release/helper/release_deb.sh Outdated
if [ -z "${APTLY_S3_NAME}" ]; then
APTLY_S3_NAME=algorand-releases
fi
#if [ -z "${APTLY_S3_NAME}" ]; then
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the point of this if is that you can override the default

Comment thread scripts/release/helper/release_deb.sh Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual APT .deb package serving happens from algorand-releases bucket, so that would be correct.

@btoll btoll force-pushed the build_test branch 2 times, most recently from 1e479d6 to f0c2072 Compare January 13, 2020 22:53
@btoll btoll force-pushed the build_test branch 6 times, most recently from b8b78b8 to 0c71821 Compare January 14, 2020 17:01
tsachiherman
tsachiherman previously approved these changes Jan 15, 2020
Copy link
Copy Markdown
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good milestone.

Copy link
Copy Markdown
Contributor

@algobolson algobolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was merged with unsettled issues. We should expect a couple days build time the first time we try to release using these scripts.

export DEFAULTNETWORK
export PKG_ROOT=${HOME}/node_pkg
export VARIATIONS="base"
# tell underlying 'build' scripts we already built
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment was meant to go with export NO_BUILD=true

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix.

gpg -u "${SIGNING_KEY_ADDR}" --clearsign "${HASHFILE}"

cp -p "${REPO_ROOT}/installer/rpm/algorand.repo" "${HOME}/prodrepo/algorand.repo"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we lost the functionality of sign_centos_docker.sh to do the final signing of the release rpms and prodrepo

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll address this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants