Skip to content

Add data-driven utility for automatic relay configuration#66

Merged
Karmastic merged 7 commits intomasterfrom
david/ebRelays
Jun 24, 2019
Merged

Add data-driven utility for automatic relay configuration#66
Karmastic merged 7 commits intomasterfrom
david/ebRelays

Conversation

@Karmastic
Copy link
Copy Markdown
Contributor

This adds a tool algorelay that is used for checking and updating Relay configurations in DNS based on our process for mainnet. The tool works against a JSON input file providing details about relays that should be configured, and details about their configuration.
For production, this is paired with the foundation's afdb1 relay command.

@Karmastic Karmastic requested a review from tsachiherman June 20, 2019 05:49
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 20, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Shoots seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

tsachiherman
tsachiherman previously approved these changes Jun 20, 2019
Copy link
Copy Markdown
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one comment -
we. need to get rid of the zoneid; we should use the email/authkey + domainArgs to discover it dynamically and use it.
A misconfigured mismatch between the zoneid and domainArgs would Create a sub-domain under the zoneid, which is not what we want.

The functionality to extract the zoneid from the email/keyauth is already used in algons.

@Karmastic
Copy link
Copy Markdown
Contributor Author

looks good, one comment -
we. need to get rid of the zoneid; we should use the email/authkey + domainArgs to discover it dynamically and use it.
A misconfigured mismatch between the zoneid and domainArgs would Create a sub-domain under the zoneid, which is not what we want.

The functionality to extract the zoneid from the email/keyauth is already used in algons.

Can you make those change in this PR?

@Karmastic Karmastic merged commit 5ad68d2 into master Jun 24, 2019
@Karmastic Karmastic deleted the david/ebRelays branch June 24, 2019 18:39
pzbitskiy pushed a commit to pzbitskiy/go-algorand that referenced this pull request May 4, 2020
Debugger: Use ledger.appLedger in tealdbg
iansuvak pushed a commit to iansuvak/go-algorand that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants