network: don't listen if IncomingConnectionsLimit == 0#6568
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Feb 25, 2026
Merged
network: don't listen if IncomingConnectionsLimit == 0#6568gmalouf merged 1 commit intoalgorand:masterfrom
gmalouf merged 1 commit intoalgorand:masterfrom
Conversation
164102d to
e25f4d6
Compare
algorandskiy
approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6568 +/- ##
===========================================
- Coverage 63.66% 47.73% -15.93%
===========================================
Files 484 645 +161
Lines 67688 87975 +20287
===========================================
- Hits 43095 41997 -1098
- Misses 21077 43217 +22140
+ Partials 3516 2761 -755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Feb 25, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While reviewing #6554 I thought it was strange that both WS and P2P network implementations still listen for connections when the incoming connection limit is set to 0, so made this small PR.
Test Plan
Two new tests added