Skip to content

network: don't listen if IncomingConnectionsLimit == 0#6568

Merged
gmalouf merged 1 commit intoalgorand:masterfrom
cce:incoming-conns-0-no-listen
Feb 25, 2026
Merged

network: don't listen if IncomingConnectionsLimit == 0#6568
gmalouf merged 1 commit intoalgorand:masterfrom
cce:incoming-conns-0-no-listen

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Feb 24, 2026

Summary

While reviewing #6554 I thought it was strange that both WS and P2P network implementations still listen for connections when the incoming connection limit is set to 0, so made this small PR.

Test Plan

Two new tests added

@cce cce force-pushed the incoming-conns-0-no-listen branch from 164102d to e25f4d6 Compare February 24, 2026 20:39
@cce cce requested a review from algorandskiy February 24, 2026 20:39
@cce cce self-assigned this Feb 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.73%. Comparing base (791c5ae) to head (e25f4d6).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (791c5ae) and HEAD (e25f4d6). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (791c5ae) HEAD (e25f4d6)
full_coverage 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6568       +/-   ##
===========================================
- Coverage   63.66%   47.73%   -15.93%     
===========================================
  Files         484      645      +161     
  Lines       67688    87975    +20287     
===========================================
- Hits        43095    41997     -1098     
- Misses      21077    43217    +22140     
+ Partials     3516     2761      -755     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce requested a review from gmalouf February 24, 2026 23:11
@gmalouf gmalouf merged commit ee2c246 into algorand:master Feb 25, 2026
65 of 68 checks passed
@cce cce deleted the incoming-conns-0-no-listen branch March 27, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants