tests: fix stopping race in http client harness#6566
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Feb 25, 2026
Merged
tests: fix stopping race in http client harness#6566algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
There is a race in libp2phttp.go
```
select {
case <-h.httpTransport.closeListeners:
case err = <-errCh:
expectedErrCount--
}
```
h.httpTransport.closeListeners is closd in httphost.Close()
and `errCh` gets it error from Serve loop.
Because notifyAll is now async, host.Close() finishes somitimes faster
so that errCh gets a chance to be ready before `h.httpTransport.closeListeners`
The fix is very the same as WebsocketNetwork.httpdThread - is to handle
`http.ErrServerClosed` explicitly
cce
reviewed
Feb 24, 2026
gmalouf
previously approved these changes
Feb 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6566 +/- ##
===========================================
- Coverage 63.66% 47.68% -15.99%
===========================================
Files 484 645 +161
Lines 67688 87972 +20284
===========================================
- Hits 43095 41946 -1149
- Misses 21077 43264 +22187
+ Partials 3516 2762 -754
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cce
approved these changes
Feb 24, 2026
gmalouf
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for p2p-related failures as seen in this build
There is a race in libp2phttp.go
h.httpTransport.closeListeners is closd in httphost.Close() and
errChgets it error from Serve loop.Because notifyAll is now async, host.Close() finishes somitimes faster so that errCh gets a chance to be ready before
h.httpTransport.closeListenersThe fix is very the same as WebsocketNetwork.httpdThread - is to handle
http.ErrServerClosedexplicitlyTest Plan
This is a test fix