Skip to content

node: collect goroutines stacks before SIGKILL#6557

Merged
algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy:pavel/goroutines-dump-on-crash
Feb 26, 2026
Merged

node: collect goroutines stacks before SIGKILL#6557
algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy:pavel/goroutines-dump-on-crash

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

If node cannot be stopped with SIGTERM, node controller will use SIGKILL after 30s. This change calls goroutine dumper before calling SIGKILL.

Requires "EnableProfiler": true to be set in config.json

Test Plan

Manual test

@algorandskiy algorandskiy force-pushed the pavel/goroutines-dump-on-crash branch from c472e24 to c01f11c Compare February 12, 2026 20:14
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.71%. Comparing base (1d079fe) to head (dc210e2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
nodecontrol/NodeController.go 0.00% 23 Missing ⚠️
nodecontrol/algodControl.go 0.00% 1 Missing ⚠️
nodecontrol/kmdControl.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1d079fe) and HEAD (dc210e2). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (1d079fe) HEAD (dc210e2)
full_coverage 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6557       +/-   ##
===========================================
- Coverage   63.24%   47.71%   -15.53%     
===========================================
  Files         484      645      +161     
  Lines       67761    88025    +20264     
===========================================
- Hits        42858    42005      -853     
- Misses      21122    43254    +22132     
+ Partials     3781     2766     -1015     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy
Copy link
Copy Markdown
Contributor Author

This helped to diagnose #6562

gmalouf
gmalouf previously approved these changes Feb 23, 2026
@cce cce changed the title node: collect goroutinese stacks before SIGKILL node: collect goroutines stacks before SIGKILL Feb 26, 2026
Comment thread nodecontrol/NodeController.go Outdated
@algorandskiy algorandskiy requested a review from gmalouf February 26, 2026 19:16
@algorandskiy algorandskiy merged commit dbcceef into algorand:master Feb 26, 2026
60 of 62 checks passed
@algorandskiy algorandskiy deleted the pavel/goroutines-dump-on-crash branch March 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants