Skip to content

build: add golangci-lint format into make fmt#6549

Merged
algorandskiy merged 5 commits intoalgorand:masterfrom
algorandskiy:pavel/gci-fmt
Feb 10, 2026
Merged

build: add golangci-lint format into make fmt#6549
algorandskiy merged 5 commits intoalgorand:masterfrom
algorandskiy:pavel/gci-fmt

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy commented Feb 5, 2026

Summary

  1. Added formatter invocation onto Makefile:

    go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.7.1 fmt -c .golangci.yml
  2. Because the original PR lint: Add gci formatter #6536 missed some files also reformatted with

    gci write \
       -s standard \
       -s default \
       -s "prefix(github.com/algorand)" \
       -s "prefix(github.com/algorand/go-algorand)" \
       --skip-generated ./

Test Plan

This is a build enhancement

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.74%. Comparing base (a64eadd) to head (94dea4b).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (a64eadd) and HEAD (94dea4b). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a64eadd) HEAD (94dea4b)
full_coverage 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6549       +/-   ##
===========================================
- Coverage   63.74%   47.74%   -16.00%     
===========================================
  Files         484      645      +161     
  Lines       67520    87846    +20326     
===========================================
- Hits        43040    41942     -1098     
- Misses      20976    43146    +22170     
+ Partials     3504     2758      -746     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy requested review from cce and jannotti February 6, 2026 00:03
@algorandskiy algorandskiy marked this pull request as ready for review February 6, 2026 01:16
Comment thread Makefile Outdated
@algorandskiy algorandskiy changed the title build: add gci into make fmt build: add golangci-lint format into make fmt Feb 6, 2026
Comment thread Makefile Outdated
Comment thread util/metrics/reporter.go
"strings"
"time"
// logging imports metrics so that we can have metrics about logging, which is more important than the four Debug lines we had here logging about metrics. TODO: find a more clever cycle resolution
//"github.com/algorand/go-algorand/logging"
Copy link
Copy Markdown
Contributor

@cce cce Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I guess at one point, an author felt this was important to note here, the answer is a tiny Logger { Debug() } interface, i think I even had a branch once that fixed this TODO so i could do debug logging from the reporter, but it's OK to remove IMO

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, I restored when switched to golangci (since it tolerated it) but looks like because the file was modified it wiped it out on re-run. Restored again.

Comment thread Makefile
Copy link
Copy Markdown
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm ok with this, as long as it doesn't explicitly disagree with gopls. I'm ok with it being stronger, as long as gopls doesn't explicitly change things back.

@algorandskiy algorandskiy merged commit 74a6d9b into algorand:master Feb 10, 2026
39 checks passed
@algorandskiy algorandskiy deleted the pavel/gci-fmt branch March 16, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants