build: add golangci-lint format into make fmt#6549
build: add golangci-lint format into make fmt#6549algorandskiy merged 5 commits intoalgorand:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6549 +/- ##
===========================================
- Coverage 63.74% 47.74% -16.00%
===========================================
Files 484 645 +161
Lines 67520 87846 +20326
===========================================
- Hits 43040 41942 -1098
- Misses 20976 43146 +22170
+ Partials 3504 2758 -746
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fcb35ae to
08d6693
Compare
| "strings" | ||
| "time" | ||
| // logging imports metrics so that we can have metrics about logging, which is more important than the four Debug lines we had here logging about metrics. TODO: find a more clever cycle resolution | ||
| //"github.com/algorand/go-algorand/logging" |
There was a problem hiding this comment.
nit: I guess at one point, an author felt this was important to note here, the answer is a tiny Logger { Debug() } interface, i think I even had a branch once that fixed this TODO so i could do debug logging from the reporter, but it's OK to remove IMO
There was a problem hiding this comment.
heh, I restored when switched to golangci (since it tolerated it) but looks like because the file was modified it wiped it out on re-run. Restored again.
jannotti
left a comment
There was a problem hiding this comment.
I think I'm ok with this, as long as it doesn't explicitly disagree with gopls. I'm ok with it being stronger, as long as gopls doesn't explicitly change things back.
Summary
Added formatter invocation onto Makefile:
Because the original PR lint: Add gci formatter #6536 missed some files also reformatted with
Test Plan
This is a build enhancement