Skip to content

API: Enhance /v2/accounts to conditionally exclude app and asset parameters#6547

Merged
gmalouf merged 8 commits intoalgorand:masterfrom
gmalouf:applications-endpoint-streamlining
Feb 6, 2026
Merged

API: Enhance /v2/accounts to conditionally exclude app and asset parameters#6547
gmalouf merged 8 commits intoalgorand:masterfrom
gmalouf:applications-endpoint-streamlining

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented Feb 4, 2026

Summary

Enhance /v2/accounts exclude parameter to help address issue #6533.

Add support for comma-delimited exclude values to allow selective exclusion of created-apps-params and created-assets-params. This reduces response size for accounts with many created applications or assets without excluding other account data. The exclude parameter now supports:

  • all: exclude all optional data (existing behavior)
  • none: include all data (default)
  • created-apps-params: exclude only created application parameters
  • created-assets-params: exclude only created asset parameters
  • Multiple values can be comma-separated

Test Plan

Added additional test cases for ensuring can exclude app and asset params simultaneously, specifying all/none in comma-delimited form not being allowed. Other tests had to be updated as the params fields on Applications and Asset API types are now optional.

…#6533.

Add support for comma-delimited exclude values to allow selective exclusion of created-apps-params and created-assets-params. This reduces response size for accounts with many created applications or assets without excluding other account data. The exclude parameter now supports:
- all: exclude all optional data (existing behavior)
- none: include all data (default)
- created-apps-params: exclude only created application parameters
- created-assets-params: exclude only created asset parameters
- Multiple values can be comma-separated
@gmalouf gmalouf self-assigned this Feb 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 26.21359% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.75%. Comparing base (a64eadd) to head (9cbbadb).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
daemon/algod/api/server/v2/handlers.go 0.00% 28 Missing ⚠️
libgoal/libgoal.go 0.00% 13 Missing ⚠️
daemon/algod/api/server/v2/account.go 42.85% 6 Missing and 6 partials ⚠️
daemon/algod/api/server/v2/dryrun.go 60.71% 8 Missing and 3 partials ⚠️
shared/pingpong/accounts.go 0.00% 8 Missing ⚠️
cmd/tealdbg/dryrunRequest.go 25.00% 2 Missing and 1 partial ⚠️
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a64eadd) and HEAD (9cbbadb). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a64eadd) HEAD (9cbbadb)
full_coverage 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6547       +/-   ##
===========================================
- Coverage   63.74%   47.75%   -16.00%     
===========================================
  Files         484      645      +161     
  Lines       67520    87846    +20326     
===========================================
- Hits        43040    41950     -1090     
- Misses      20976    43140    +22164     
+ Partials     3504     2756      -748     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf requested a review from jannotti February 4, 2026 19:19
@gmalouf gmalouf marked this pull request as ready for review February 4, 2026 19:19
@gmalouf gmalouf requested a review from algorandskiy February 4, 2026 20:00
@gmalouf gmalouf linked an issue Feb 4, 2026 that may be closed by this pull request
Comment thread daemon/algod/api/algod.oas2.json Outdated
Comment thread daemon/algod/api/algod.oas2.json
Comment thread daemon/algod/api/server/v2/dryrun.go
Comment thread daemon/algod/api/algod.oas2.json Outdated
Comment thread daemon/algod/api/server/v2/account.go Outdated
Comment thread daemon/algod/api/server/v2/dryrun.go
Comment thread daemon/algod/api/server/v2/handlers.go Outdated
Comment thread test/e2e-go/features/accountPerf/sixMillion_test.go Outdated
@gmalouf gmalouf requested a review from jannotti February 4, 2026 20:35
…ck-nil-params

Add nil params checks to copy functions in case of exclude
@gmalouf gmalouf requested review from algorandskiy and cce February 5, 2026 21:40
Comment thread daemon/algod/api/server/v2/dryrun.go
Copy link
Copy Markdown
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I guess there is some inconsistency in the nil checking but most of it happens after ValidateApps so 🤷 ?

@gmalouf gmalouf merged commit 8b384d2 into algorand:master Feb 6, 2026
39 checks passed
@gmalouf gmalouf deleted the applications-endpoint-streamlining branch February 6, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/v2/accounts return created application IDs without params

4 participants