tests: fix flaky fetcher, catchpoint, expect tests#6546
Merged
algorandskiy merged 5 commits intoalgorand:masterfrom Mar 2, 2026
Merged
tests: fix flaky fetcher, catchpoint, expect tests#6546algorandskiy merged 5 commits intoalgorand:masterfrom
algorandskiy merged 5 commits intoalgorand:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6546 +/- ##
===========================================
- Coverage 61.89% 47.76% -14.14%
===========================================
Files 484 645 +161
Lines 67571 87846 +20275
===========================================
+ Hits 41822 41957 +135
- Misses 22184 43131 +20947
+ Partials 3565 2758 -807
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Feb 6, 2026
767741a to
68ebf79
Compare
gmalouf
approved these changes
Feb 17, 2026
jannotti
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestRequestBlockBytesErrorsas seen here. Caused by a specific assert when running block fetching on pre-cancelled context. In this caseRequestraces with asyncRespondso both response channel andcontext.Doneare ready. Fixed by adding context cancellation pre-check in the function prologue.GLOBAL_TEST_ALGO_DIRclearing in expect tests causing error like this.TestCatchpointAfterTxnsby forcing trackers to flush before creating catchpoints.TestExactAccountChunkas seen in this master branch build failureTest Plan
Flaky test fixes