CICD: fix packaging with regards to binary changes#6539
CICD: fix packaging with regards to binary changes#6539onetechnical merged 11 commits intoalgorand:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes broken packaging scripts for Debian and RPM distributions after binary reorganization in #6503. The changes update binary paths and remove deprecated tools from the main package list.
Changes:
- Updated packaging scripts to use new
ALGO_TOOLSpath for devtools binaries (carpenter, msgpacktool, tealdbg) - Removed hardcoded
/usr/local/go/bin/paths in favor of systemgocommand - Reorganized binary file lists to correctly separate main binaries from development tools
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release/mule/package/rpm/package.sh | Added ALGO_TOOLS variable definition and export for RPM packaging |
| scripts/release/mule/package/deb/package.sh | Added ALGO_TOOLS variable, restructured binary copying logic for devtools vs main package, removed hardcoded go paths |
| scripts/build_package.sh | Moved msgpacktool and tealdbg from bin_files to tools bin_files |
| scripts/build_deb.sh | Removed carpenter, msgpacktool, and tealdbg from main package bin_files |
| installer/rpm/algorand-devtools/algorand-devtools.spec | Updated to use ALGO_TOOLS instead of ALGO_BIN for devtools installation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3fa6f7a to
926e5d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6539 +/- ##
==========================================
- Coverage 47.90% 47.77% -0.13%
==========================================
Files 662 655 -7
Lines 87991 87912 -79
==========================================
- Hits 42149 42001 -148
- Misses 43085 43145 +60
- Partials 2757 2766 +9 ☔ View full report in Codecov by Sentry. |
cce
left a comment
There was a problem hiding this comment.
LGTM! sorry i missed these when i moved some things from the main package to tools
Summary
After #6503 some binaries were removed and paths to others were changed. As a result, packaging for debs and rpms was broken.
This PR fixes this by shifting binaries and updating to set the tools path, as well as removing some deprecations.
Test Plan
Verified debian and rpm package scripts completed and package lists seemed correct