Skip to content

CICD: fix packaging with regards to binary changes#6539

Merged
onetechnical merged 11 commits intoalgorand:masterfrom
onetechnical:fix-packaging
Feb 3, 2026
Merged

CICD: fix packaging with regards to binary changes#6539
onetechnical merged 11 commits intoalgorand:masterfrom
onetechnical:fix-packaging

Conversation

@onetechnical
Copy link
Copy Markdown
Contributor

@onetechnical onetechnical commented Feb 2, 2026

Summary

After #6503 some binaries were removed and paths to others were changed. As a result, packaging for debs and rpms was broken.

This PR fixes this by shifting binaries and updating to set the tools path, as well as removing some deprecations.

Test Plan

Verified debian and rpm package scripts completed and package lists seemed correct

@onetechnical onetechnical self-assigned this Feb 2, 2026
@onetechnical onetechnical requested a review from Copilot February 2, 2026 20:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes broken packaging scripts for Debian and RPM distributions after binary reorganization in #6503. The changes update binary paths and remove deprecated tools from the main package list.

Changes:

  • Updated packaging scripts to use new ALGO_TOOLS path for devtools binaries (carpenter, msgpacktool, tealdbg)
  • Removed hardcoded /usr/local/go/bin/ paths in favor of system go command
  • Reorganized binary file lists to correctly separate main binaries from development tools

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/release/mule/package/rpm/package.sh Added ALGO_TOOLS variable definition and export for RPM packaging
scripts/release/mule/package/deb/package.sh Added ALGO_TOOLS variable, restructured binary copying logic for devtools vs main package, removed hardcoded go paths
scripts/build_package.sh Moved msgpacktool and tealdbg from bin_files to tools bin_files
scripts/build_deb.sh Removed carpenter, msgpacktool, and tealdbg from main package bin_files
installer/rpm/algorand-devtools/algorand-devtools.spec Updated to use ALGO_TOOLS instead of ALGO_BIN for devtools installation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onetechnical onetechnical changed the base branch from rel/beta to master February 2, 2026 20:23
algorandskiy
algorandskiy previously approved these changes Feb 3, 2026
Comment thread scripts/release/mule/package/deb/package.sh
@algorandskiy algorandskiy requested a review from cce February 3, 2026 00:58
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.77%. Comparing base (172f19d) to head (46f0770).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6539      +/-   ##
==========================================
- Coverage   47.90%   47.77%   -0.13%     
==========================================
  Files         662      655       -7     
  Lines       87991    87912      -79     
==========================================
- Hits        42149    42001     -148     
- Misses      43085    43145      +60     
- Partials     2757     2766       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! sorry i missed these when i moved some things from the main package to tools

@onetechnical onetechnical merged commit 5ae5c5a into algorand:master Feb 3, 2026
61 of 64 checks passed
@onetechnical onetechnical deleted the fix-packaging branch February 3, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants