Skip to content

tests: fix some flaky tests - p2p, ledger, e2e-subs#6534

Merged
algorandskiy merged 6 commits intoalgorand:masterfrom
algorandskiy:pavel/test-fixes-2026-01.2
Feb 2, 2026
Merged

tests: fix some flaky tests - p2p, ledger, e2e-subs#6534
algorandskiy merged 6 commits intoalgorand:masterfrom
algorandskiy:pavel/test-fixes-2026-01.2

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy commented Jan 28, 2026

Summary

  1. Fixed p2p tests race condition between data change and test assertions
  2. fixed ledger tests data race as seen here
  3. Fixed TestBoxAccountData with sleep: 40s -> 1.6s
  4. Fixed round check in subs/absentee.py as seen here

Also removed a contraversal reflect check in MakeTxHandler introduced recent PR.

Test Plan

These are test fixes

gmalouf
gmalouf previously approved these changes Jan 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.78%. Comparing base (172f19d) to head (2bda4fe).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
- Coverage   47.90%   47.78%   -0.12%     
==========================================
  Files         662      655       -7     
  Lines       87991    87903      -88     
==========================================
- Hits        42149    42003     -146     
- Misses      43085    43141      +56     
- Partials     2757     2759       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread network/p2pNetwork_test.go
@algorandskiy algorandskiy changed the title tests: fix some flaky p2p tests tests: fix some flaky tests - p2p, ledger, e2e-subs Jan 29, 2026
Comment thread data/txHandler_test.go
gmalouf
gmalouf previously approved these changes Jan 29, 2026
Comment thread ledger/boxtxn_test.go
@algorandskiy algorandskiy merged commit 7437021 into algorand:master Feb 2, 2026
61 of 72 checks passed
@algorandskiy algorandskiy deleted the pavel/test-fixes-2026-01.2 branch March 16, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants