Skip to content

config: rename IsGossipServer => IsListenServer#6525

Merged
gmalouf merged 1 commit intoalgorand:masterfrom
cce:IsListenServer
Jan 14, 2026
Merged

config: rename IsGossipServer => IsListenServer#6525
gmalouf merged 1 commit intoalgorand:masterfrom
cce:IsListenServer

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Jan 13, 2026

Summary

As discussed in #6516 the config helper function name IsGossipServer() is confusing because it implies a connection to the "gossip service". It actually checks if algod has been configured to listen for incoming connections, whether or not the gossip service is enabled.

Test Plan

Name-only change, no code changed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.69%. Comparing base (a5d7ec2) to head (254877a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
daemon/algod/server.go 0.00% 3 Missing ⚠️
node/follower_node.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6525      +/-   ##
==========================================
- Coverage   47.85%   47.69%   -0.16%     
==========================================
  Files         662      655       -7     
  Lines       87940    87855      -85     
==========================================
- Hits        42082    41903     -179     
- Misses      43093    43180      +87     
- Partials     2765     2772       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce changed the title config: change IsGossipServer => IsListenServer config: rename IsGossipServer => IsListenServer Jan 14, 2026
@gmalouf gmalouf merged commit f9951ff into algorand:master Jan 14, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants