tests: fix flaky e2e multisig tests#6475
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Oct 24, 2025
Merged
Conversation
ade26d4 to
d615185
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky e2e multisig tests caused by race conditions when piping msgpacktool -d output to grep -q. The issue occurs because grep -q exits immediately after finding a match, which can cause msgpacktool to receive EPIPE while still writing, resulting in non-zero exit status under set -o pipefail.
Key Changes:
- Split the pipeline operation into two separate steps: decode to file, then grep the file
- Eliminates the race condition by ensuring
msgpacktoolcompletes beforegrepruns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/scripts/e2e_subs/v32/e2e-teal-multisig.sh | Breaks pipeline into separate decode and grep steps for v32 legacy mode test |
| test/scripts/e2e_subs/e2e-teal-multisig.sh | Breaks pipeline into separate decode and grep steps for future consensus mode test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
algorandskiy
approved these changes
Oct 24, 2025
jannotti
reviewed
Oct 24, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
We should probably comment on this, so that someone doesn't tidy it up some day to avoid the temp file.
gmalouf
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the multisig e2e tests,
msgpacktool -d | grep -qruns underset -o pipefail, so whengrep -qexits right after matching "lmsig"/"msig", msgpacktool might still be writing and encounter EPIPE, leading to a non-zero status reported and a failed test.Test Plan
Tests should be hopefully less flaky.