Skip to content

test: fix logging after TestP2PHTTPHandler finishes #6469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cce merged 2 commits into from
Oct 27, 2025
Merged

test: fix logging after TestP2PHTTPHandler finishes #6469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0348c00
fix logging after TestP2PHTTPHandler finishes
cce Oct 21, 2025
32b66dd
also stop in some other uses of NewP2PNetwork
cce Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion network/p2pNetwork_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,8 @@ func TestP2PNetworkAddress(t *testing.T) {
cfg := config.GetDefaultLocal()
log := logging.TestingLog(t)
netA, err := NewP2PNetwork(log, cfg, "", nil, GenesisInfo{genesisID, config.Devtestnet}, &nopeNodeInfo{}, nil, nil)
defer netA.Stop()
require.NoError(t, err)
defer netA.Stop()
addrInfo := netA.service.AddrInfo()
// close the real service since we will substitute a mock one
netA.service.Close()
Expand Down Expand Up @@ -801,6 +801,8 @@ func TestP2PHTTPHandler(t *testing.T) {
// zero clients allowed, rate limiting window (10s) is greater than queue deadline (1s)
netB, err := NewP2PNetwork(log, cfg, "", nil, GenesisInfo{genesisID, config.Devtestnet}, &nopeNodeInfo{}, nil, nil)
require.NoError(t, err)
defer netB.Stop() // even though netB.Start is not called, NewP2PNetwork creates goroutines to stop
Comment thread
cce marked this conversation as resolved.
Comment thread
cce marked this conversation as resolved.

pstore, err := peerstore.MakePhonebook(0, 10*time.Second)
require.NoError(t, err)
pstore.AddPersistentPeers([]*peer.AddrInfo{&peerInfoA}, "net", phonebook.RelayRole)
Expand Down Expand Up @@ -1426,6 +1428,7 @@ func TestP2PTxTopicValidator_NoWsPeer(t *testing.T) {

net, err := NewP2PNetwork(log, cfg, "", nil, GenesisInfo{genesisID, config.Devtestnet}, &nopeNodeInfo{}, nil, nil)
require.NoError(t, err)
defer net.Stop()

peerID := peer.ID("12345678") // must be 8+ in size
msg := pubsub.Message{Message: &pb.Message{}, ID: string(peerID)}
Expand Down Expand Up @@ -1455,6 +1458,7 @@ func TestGetPeersFiltersSelf(t *testing.T) {

net, err := NewP2PNetwork(log, cfg, t.TempDir(), []string{}, GenesisInfo{"test-genesis", "test-network"}, &nopeNodeInfo{}, nil, nil)
require.NoError(t, err)
defer net.Stop()
selfID := net.service.ID()

// Create and add self
Expand Down
Loading