agreement: faster TestRandomizedEncodingFullDiskState#6462
Merged
cce merged 3 commits intoalgorand:masterfrom Oct 8, 2025
Merged
agreement: faster TestRandomizedEncodingFullDiskState#6462cce merged 3 commits intoalgorand:masterfrom
cce merged 3 commits intoalgorand:masterfrom
Conversation
gmalouf
previously approved these changes
Oct 8, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the TestRandomizedEncodingFullDiskState test which became 7x slower after a previous change. The optimization adds bounds to randomized collection sizes and provides configuration options to silence warning messages during testing.
- Added configuration options to limit randomized slice/map lengths and silence allocation warnings
- Modified test to use smaller collection sizes (8 instead of 32) and fewer iterations (1000/500 instead of 5000)
- Updated randomization functions to accept and use the new configuration parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| protocol/codec_tester.go | Added configuration options for max collection length and silencing warnings, updated randomization logic to use these bounds |
| agreement/persistence_test.go | Applied new configuration options to limit test execution time and reduce collection sizes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jannotti
approved these changes
Oct 8, 2025
gmalouf
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The change in #6455 removed msgp.Raw from the
messagetype which meanterrSkipRawMsgpTestingwas no longer returned when callingprotocol.RandomizeObjectinTestRandomizedEncodingFullDiskState. This made the test 7x slower (~75s to ~530s). These changes hope to bound the number of iterations and size of random maps/slices made to keep the test times faster. In this PR it takes 27s.Test Plan
Existing test should pass and not take longer than 10m