Eval: Make counts and maxCounts simple values, not pointers#6442
Merged
jannotti merged 1 commit intoalgorand:masterfrom Sep 17, 2025
Merged
Eval: Make counts and maxCounts simple values, not pointers#6442jannotti merged 1 commit intoalgorand:masterfrom
jannotti merged 1 commit intoalgorand:masterfrom
Conversation
It's makes it clearer that there is no sharing among the storageDeltas. There was no sharing, because each pointed to object was freshly allocated, but using a pointer obscured that fact (and performed a wasted allocation. This change will make it easier (or at least clearer) to make changes to `maxCounts` if we allow transactions that update an app's global schema.
algorandskiy
approved these changes
Sep 16, 2025
cce
approved these changes
Sep 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies memory management by changing counts and maxCounts fields in storageDelta from pointers to simple values, eliminating unnecessary pointer allocations while clarifying that no sharing occurs between storage deltas.
- Changed
countsandmaxCountsfields from*basics.StateSchematobasics.StateSchema - Updated all assignments and comparisons to work with value types instead of pointers
- Improved test assertions using
require.ErrorContainsfor better readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ledger/eval/appcow.go | Modified storageDelta struct to use value types and updated all field assignments |
| ledger/eval/appcow_test.go | Updated test code to work with value types and improved error assertions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
algorandskiy
pushed a commit
to algorandskiy/go-algorand
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes it clearer that there is no sharing among the storageDeltas. There was no sharing, because each pointed to object was freshly allocated, but using a pointer obscured that fact (and performed a wasted allocation.
This change will make it easier (or at least clearer) to make changes to
maxCountsif we allow transactions that update an app's global schema.Test Plan