AVM: Prepare for falcon_verify in v12

[jannotti]

sumhash is staying experimental until a use case is shown

Summary

Test Plan

[gemini-code-assist]

Summary of Changes

Hello @jannotti, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the codebase for the upcoming Logic Version 12 by explicitly assigning the falcon_verify opcode to it. Concurrently, it introduces a new experimental Logic Version 13, specifically for the sumhash512 opcode, indicating that sumhash512 remains experimental for now. The changes involve updating core version constants and adapting the testing framework to accommodate these new versioning distinctions, ensuring future compatibility and clear separation of features.

Highlights

• Falcon Verify Versioning: The falcon_verify opcode is now explicitly tied to Logic Version 12.
• Sumhash512 Versioning: The sumhash512 opcode is now explicitly tied to a new experimental Logic Version 13.
• Logic Version Update: The overall LogicVersion constant has been incremented to 13.
• Test Infrastructure Updates: Test infrastructure, including constants, maps, and test cases, has been updated to support and differentiate between Logic Version 12 and the new experimental Logic Version 13.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request prepares for the inclusion of falcon_verify in AVM v12 and keeps sumhash experimental by moving it to v13. The changes are consistent across opcode definitions, tests, and version constants. The logic version is correctly bumped to 13. I have a couple of minor suggestions to improve consistency in the test files.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.60%. Comparing base (1960955) to head (c9733aa).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6416      +/-   ##
==========================================
- Coverage   50.81%   50.60%   -0.21%     
==========================================
  Files         664      657       -7     
  Lines      111373   111275      -98     
==========================================
- Hits        56596    56315     -281     
- Misses      51904    52074     +170     
- Partials     2873     2886      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.