Skip to content

CI: remove t.Parallel() from TestAbsentTracking#6415

Merged
cce merged 1 commit intoalgorand:masterfrom
cce:absent-tracking-test
Aug 26, 2025
Merged

CI: remove t.Parallel() from TestAbsentTracking#6415
cce merged 1 commit intoalgorand:masterfrom
cce:absent-tracking-test

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Aug 21, 2025

Summary

A tiny change to make this resource-intensive test a little less flaky.

Test Plan

Should pass

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in the TestAbsentTracking function by removing its t.Parallel() call. The test is identified as resource-intensive and prone to flakiness due to heavy disk usage, and this change aims to stabilize its execution.

Highlights

  • Test Flakiness Mitigation: Removed t.Parallel() from TestAbsentTracking in ledger/eval_simple_test.go to address flakiness, as this test is resource-intensive and interacts heavily with disk.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes t.Parallel() from the TestAbsentTracking test to make it less flaky in CI. Given that this is a resource-intensive test, running it sequentially is a sensible approach to improve stability by avoiding resource contention. The change is minimal, targeted, and well-justified. I approve.

@cce cce requested a review from onetechnical August 22, 2025 23:27
@cce cce requested a review from jannotti August 26, 2025 01:03
@cce cce merged commit efcac3f into algorand:master Aug 26, 2025
61 of 67 checks passed
@cce cce deleted the absent-tracking-test branch August 26, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants