Skip to content

Chore: Remove an unneeded consensus flag to simplify work on big programs#6392

Merged
jannotti merged 1 commit intoalgorand:masterfrom
jannotti:eliminate-epp-flag
Aug 6, 2025
Merged

Chore: Remove an unneeded consensus flag to simplify work on big programs#6392
jannotti merged 1 commit intoalgorand:masterfrom
jannotti:eliminate-epp-flag

Conversation

@jannotti
Copy link
Copy Markdown
Contributor

@jannotti jannotti commented Jul 24, 2025

This removes a consensus parameter to make my life easier when introducing bigger programs.

Summary

Test Plan

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.53%. Comparing base (8f33ac2) to head (32588ad).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
data/transactions/application.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6392      +/-   ##
==========================================
+ Coverage   42.55%   50.53%   +7.97%     
==========================================
  Files         661      654       -7     
  Lines      110771   110664     -107     
==========================================
+ Hits        47136    55921    +8785     
+ Misses      60665    51871    -8794     
+ Partials     2970     2872      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti force-pushed the eliminate-epp-flag branch from eb55eb9 to 4c9ad8e Compare July 25, 2025 00:27
@jannotti jannotti changed the title Remove an unneeded consensus flag to simplify work on big programs Chore: Remove an unneeded consensus flag to simplify work on big programs Jul 25, 2025
@jannotti jannotti self-assigned this Jul 25, 2025
@jannotti jannotti marked this pull request as ready for review July 25, 2025 01:20
@jannotti
Copy link
Copy Markdown
Contributor Author

I'm in no hurry to merge this given a pending release, but I'd like to get it reviewed and into a mergable state.

@jannotti jannotti requested review from algorandskiy, cce and gmalouf July 25, 2025 01:21
@jannotti jannotti force-pushed the eliminate-epp-flag branch from 4c9ad8e to 32588ad Compare July 28, 2025 14:56
Comment thread data/transactions/application_test.go Outdated
@jannotti jannotti force-pushed the eliminate-epp-flag branch from 32588ad to b096bba Compare August 5, 2025 22:07
algorandskiy
algorandskiy previously approved these changes Aug 6, 2025
gmalouf
gmalouf previously approved these changes Aug 6, 2025
@jannotti jannotti dismissed stale reviews from gmalouf and algorandskiy via 3f0ff66 August 6, 2025 14:43
@jannotti jannotti force-pushed the eliminate-epp-flag branch from b096bba to 3f0ff66 Compare August 6, 2025 14:43
@jannotti jannotti merged commit af7e67a into algorand:master Aug 6, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants