Dev: fix darwin universal targets#6383
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Jul 17, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6383 +/- ##
==========================================
- Coverage 50.62% 50.42% -0.21%
==========================================
Files 660 653 -7
Lines 110513 110415 -98
==========================================
- Hits 55943 55672 -271
- Misses 51715 51879 +164
- Partials 2855 2864 +9 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Jul 17, 2025
cce
approved these changes
Jul 17, 2025
gmalouf
approved these changes
Jul 17, 2025
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #6378 the universal targets for darwin builds was broken, due to the GOBIN refactoring.
This PR cleans this up by explicitly copying the NONGO_BIN files. Additionally, the clean target was edited to remove the cross-compilation directories.
Test Plan
Ran the following targets locally, after removing $GOBIN, $GOBIN-darwin-arm64, and $GOBIN-darwin-amd64 directories.