network: do not use telemetry id for p2p nets#6381
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Jul 16, 2025
Merged
network: do not use telemetry id for p2p nets#6381algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6381 +/- ##
==========================================
- Coverage 50.62% 50.42% -0.21%
==========================================
Files 660 653 -7
Lines 110513 110415 -98
==========================================
- Hits 55952 55681 -271
- Misses 51704 51868 +164
- Partials 2857 2866 +9 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Jul 15, 2025
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
Should this be behind an option such that known nodes could choose to have it on?
cce
approved these changes
Jul 16, 2025
Contributor
|
We could maybe revisit this later if a concept of trusted peers is introduced. This can be seen in other libp2p network implementations, a way to have a trusted list of peers they contact (if you only want to connect to your own infra, or trusted infra you have a relationship with). |
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent p2p from exposing own telemetry ids.
Test Plan
Existing tests