refactor: use maps.Copy for cleaner map handling#6373
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Jul 18, 2025
Merged
refactor: use maps.Copy for cleaner map handling#6373gmalouf merged 1 commit intoalgorand:masterfrom
gmalouf merged 1 commit intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6373 +/- ##
==========================================
+ Coverage 49.81% 50.60% +0.78%
==========================================
Files 356 653 +297
Lines 64417 110782 +46365
==========================================
+ Hits 32091 56060 +23969
- Misses 30970 51862 +20892
- Partials 1356 2860 +1504 ☔ View full report in Codecov by Sentry. |
jannotti
requested changes
Jul 1, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
Isn't maps.Clone() better here, to do the allocation too?
Signed-off-by: sellskin <mydesk@yeah.net>
Contributor
Author
|
gmalouf
approved these changes
Jul 18, 2025
jannotti
approved these changes
Jul 18, 2025
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
Test Plan