Skip to content

CICD: fix short test flag and up parallelism #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onetechnical merged 6 commits into from
Jun 20, 2025
Merged

CICD: fix short test flag and up parallelism #6370

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
822c0c8
Try to up in-container parallelism while reducing instance count
onetechnical Jun 12, 2025
2522fc2
Bump up parallel flag to 8
onetechnical Jun 16, 2025
1a25e64
Try dropping to 2 just to see the effect
onetechnical Jun 16, 2025
1e58e8c
Restore -p 4 and rename SHORTTEST env var
onetechnical Jun 17, 2025
65c1d10
propagate short test flag through rest of tests and make consistent
onetechnical Jun 17, 2025
9d3ed6e
Bump expect tests to 8 partitions
onetechnical Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/ci-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
PARTITION_ID: ${{ matrix.partition_id }}
PARTITION_TOTAL: 4
CIRCLECI: true
SHORT_TEST_FLAG: "-short"
SHORTTEST: "-short"
steps:
- name: Download workspace archive
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -119,8 +119,8 @@ jobs:
gotestsum --format standard-verbose \
--junitfile ~/test_results/${{ matrix.platform }}_test/${PARTITION_ID}/results.xml \
--jsonfile ~/test_results/${{ matrix.platform }}_test/${PARTITION_ID}/testresults.json \
-- --tags "sqlite_unlock_notify sqlite_omit_load_extension" $SHORT_TEST_FLAG \
-race -timeout 1h -coverprofile=coverage.txt -covermode=atomic -p 1 \
-- --tags "sqlite_unlock_notify sqlite_omit_load_extension" $SHORTTEST \
-race -timeout 1h -coverprofile=coverage.txt -covermode=atomic -p 4 \
$PACKAGE_NAMES
- name: Notify Slack on failure
if: failure() && env.SLACK_WEBHOOK != ''
Expand Down Expand Up @@ -165,15 +165,15 @@ jobs:
fail-fast: false
matrix:
platform: ["ubuntu-24.04"]
partition_id: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15] # set PARTITION_TOTAL below to match
partition_id: [0, 1, 2, 3] # set PARTITION_TOTAL below to match
Comment thread
jannotti marked this conversation as resolved.
runs-on: ${{ matrix.platform }}
env:
CIRCLECI: true
PARTITION_ID: ${{ matrix.partition_id }}
PARTITION_TOTAL: 16
PARTITION_TOTAL: 4
E2E_TEST_FILTER: GO
PARALLEL_FLAG: "-p 1"
SHORT_TEST_FLAG: "-short"
PARALLEL_FLAG: "-p 4"
SHORTTEST: "-short"
steps:
- name: Download workspace archive
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -232,15 +232,15 @@ jobs:
fail-fast: false
matrix:
platform: ["ubuntu-24.04"]
partition_id: [0, 1, 2, 3] # set PARTITION_TOTAL below to match
partition_id: [0, 1, 2, 3, 4, 5, 6, 7] # set PARTITION_TOTAL below to match
runs-on: ${{ matrix.platform }}
env:
CIRCLECI: true
PARTITION_ID: ${{ matrix.partition_id }}
PARTITION_TOTAL: 4
PARTITION_TOTAL: 8
E2E_TEST_FILTER: EXPECT
PARALLEL_FLAG: "-p 1"
SHORT_TEST_FLAG: "-short"
PARALLEL_FLAG: "-p 4"
SHORTTEST: "-short"
steps:
- name: Download workspace archive
uses: actions/download-artifact@v4
Expand Down
Loading