Testing: test vFuture, so we are exercising branch512#6365
Merged
jannotti merged 3 commits intoalgorand:masterfrom Jun 12, 2025
Merged
Testing: test vFuture, so we are exercising branch512#6365jannotti merged 3 commits intoalgorand:masterfrom
jannotti merged 3 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
==========================================
- Coverage 50.66% 50.50% -0.16%
==========================================
Files 653 653
Lines 110377 110419 +42
==========================================
- Hits 55918 55772 -146
- Misses 51592 51771 +179
- Partials 2867 2876 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
algorandskiy
approved these changes
Jun 12, 2025
gmalouf
approved these changes
Jun 12, 2025
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to test CurrentVersion, now we test an old version, current version, and vFuture, which is a better test as we make development changes.
This also eliminates a funny source of flakiness, because the test randomly selects a different version to tuck into the header to test that it is detected as wrong. But if that random version has different rules about branch512, then it was causing a different failure than expected.
Test Plan
New test added for branch512 correctness