tests: fix testCatchpointAfterStakeLookupTxns#6363
Merged
jannotti merged 1 commit intoalgorand:masterfrom Jun 11, 2025
Merged
Conversation
gmalouf
approved these changes
Jun 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6363 +/- ##
==========================================
- Coverage 50.66% 50.48% -0.18%
==========================================
Files 653 653
Lines 110377 110377
==========================================
- Hits 55918 55729 -189
- Misses 51592 51788 +196
+ Partials 2867 2860 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannotti
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testCatchpointAfterStakeLookupTxnsuses double ledger after adding lots of blocks, and then checks accounts are persisted on the same round. But sometimes it checks too early so validator has not persisted the latest block yet so flushing withtestCatchpointFlushRounddoes flush but sometimes on a previous round.Fixed by ensuring both ledgers have the latest block persisted.
Test Plan
This is a unit test fix