tests: fix a race in TestP2PMetainfoExchange#6336
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom May 21, 2025
Merged
tests: fix a race in TestP2PMetainfoExchange#6336algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
jannotti
approved these changes
May 21, 2025
gmalouf
approved these changes
May 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6336 +/- ##
=======================================
Coverage 51.86% 51.87%
=======================================
Files 653 653
Lines 87547 87547
=======================================
+ Hits 45408 45411 +3
- Misses 39264 39265 +1
+ Partials 2875 2871 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a race between making connections and propagating peer info into peer store in TestP2PMetainfoExchange
Test Plan
This is a test fix