Merged
Conversation
algorandskiy
reviewed
Apr 2, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6289 +/- ##
==========================================
- Coverage 51.62% 51.61% -0.02%
==========================================
Files 647 647
Lines 86882 86893 +11
==========================================
- Hits 44855 44847 -8
- Misses 39166 39182 +16
- Partials 2861 2864 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
algorandskiy
approved these changes
Apr 3, 2025
gmalouf
approved these changes
Apr 8, 2025
This was referenced May 15, 2025
cce
added a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We don't need to lower the current RLIMIT_NOFILE limit, which we were doing before. This ensures that we only raise it if needed. It also adds a constant number of additional FDs to the requested limit if P2P is enabled. This constant is arbitrary, we could decide to adjust it, or make it a separate configuration value.
Test Plan
Existing tests should pass.