kmd: upgrade karalabe/usb to karalabe/hid#6282
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Mar 19, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6282 +/- ##
==========================================
- Coverage 51.68% 51.66% -0.02%
==========================================
Files 647 647
Lines 86907 86907
==========================================
- Hits 44916 44901 -15
- Misses 39126 39135 +9
- Partials 2865 2871 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
algorandskiy
approved these changes
Mar 18, 2025
jannotti
approved these changes
Mar 18, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
While is seems scary to update a low-level package that interacts with Ledgers, we're really trusting the same org/person (karalabe) and following the lead of Ethereum. I'm ok.
cce
approved these changes
Mar 19, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having been unable to use a Ledger device with
goalon Mac for many months I finally tracked down the issue. The HID Path length specifically on my Mac was too long, and as a result was being replaced with an empty string"". This meant my Ledger would never show ingoal wallet list, despite working everywhere else.It turns out https://github.com/karalabe/usb embeds an old version of the https://github.com/signal11/hidapi implementation that uses Apple's io_string_t type for the path.
After reading similar issues in various repos, it seems karalabe/hid#44 was the solution that updates the underlying issue, and then go-ethereum ultimately moved to this package last year with almost identical changes to the code.