util: implement GetTotalMemory for mac and windows#6272
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Mar 13, 2025
Merged
util: implement GetTotalMemory for mac and windows#6272algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
jannotti
reviewed
Mar 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6272 +/- ##
=======================================
Coverage 51.69% 51.70%
=======================================
Files 646 647 +1
Lines 86860 86858 -2
=======================================
+ Hits 44901 44906 +5
+ Misses 39095 39084 -11
- Partials 2864 2868 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmalouf
approved these changes
Mar 11, 2025
jannotti
approved these changes
Mar 13, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly macos build failed with
Implemented
GetTotalMemoryfor macos and windows.Test Plan
Added a unit test.