test: add OverrideKmdConfig to libgoalFixture

[algorandskiy]

Summary

Sometimes e2e tests fail with handle does not exist error. It ended up to be a wallet handle expiration issue: tests get a handle at the very beginning and keep using it till the end. Handle expiration is 60 seconds and a test can take longer. KMD starts a background thread that removes handles after expiration and there is no way to renew if it was removed.

To solve this I added a new KmdJSONOverride field to network templates (similar to ConfigJSONOverride) to set SessionLifetimeSecs to 5 minutes. At the moment modified only TwoNodes50Each.json and TwoNodes50EachFuture.json templates as the most common ones and ones with such failures.

Solved with adding OverrideKmdConfig to netdeploy and using it in libgoalFixture.
This solves e2e-go tests but not expect or sub-e2e tests.

Test Plan

Run some existing e2e tests locally.

[codecov]

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (269945c) to head (e5f179a).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
netdeploy/networkTemplate.go	8.69%	21 Missing ⚠️
daemon/kmd/config/config.go	0.00%	8 Missing ⚠️
netdeploy/network.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6269      +/-   ##
==========================================
- Coverage   51.78%   51.76%   -0.02%     
==========================================
  Files         644      644              
  Lines       86697    86727      +30     
==========================================
- Hits        44894    44893       -1     
- Misses      38933    38966      +33     
+ Partials     2870     2868       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jannotti]

It seems strange that this becomes a property of the network, as opposed to a configuration when running KMD itself. They seem very different. Can our tests just start KMD is some special way? That way the .json files stay the same, and all the tests work.

[algorandskiy]

Currently libgoalFixture uses netdeploy.CreateNetworkFromTemplate that takes a template. I guess it is possible to add another method and some non-exported properly on NetworkTemplate type to include store and apply kmd config values.

[algorandskiy]

Okay, now I recall why I went this road. We cannot create KMD config from outside since it has kmd dir and it is not known unless template instantiation moment. So NetworkTemplate must have it is own type defining some subset of KMD config that needs to merged with the default one when KMD dir is known.

[algorandskiy]

Implemented netdeploy's OverrideKmdConfig used in libgoalFixture.

[gmalouf]

Looks like one comment wants to get in, otherwise looks fine.