network: fix peerstore Get/Put races

[algorandskiy]

Summary

Fix for a race condition seen in this test run

peerstore's GetConnectionWaitTime gets a peerstore entry, calculates number of recentConnectionTimes to remove and then calls popNElements that also gets the same entry from peerstore and attempts to remove number of entries calculated on the first copy.

Fixed by removing the addressData mutex and adding it to PeerStore itself. Otherwise all these PeerStore methods are racy.

Test Plan

Existing tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.18%. Comparing base (02bfca4) to head (f886280).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6261      +/-   ##
==========================================
- Coverage   51.80%   50.18%   -1.62%     
==========================================
  Files         644      644              
  Lines       86643    86644       +1     
==========================================
- Hits        44886    43484    -1402     
- Misses      38887    40219    +1332     
- Partials     2870     2941      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cce]

OK, big lock is easier for reader to understand, LGTM!