tests: fix flaky TestLedgerErrorValidate#6259
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Feb 20, 2025
Merged
Conversation
jannotti
approved these changes
Feb 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6259 +/- ##
==========================================
+ Coverage 51.76% 51.77% +0.01%
==========================================
Files 644 644
Lines 86506 86506
==========================================
+ Hits 44777 44792 +15
+ Misses 38852 38842 -10
+ Partials 2877 2872 -5 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6190 introduced retry callbacks and the
TestLedgerErrorValidatetest with its in-memory ledger was not quite ready for receiving such message that is normal/expected for that kind of concurrent test like this with in-memory ledger.Test Plan
This is a test fix